-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Settings public API #163400
[Uptime] Settings public API #163400
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
af07fed
to
7307b3b
Compare
87a5920
to
363862c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AO changes LGTM with code review only.
Pinging @elastic/uptime (Team:uptime) |
2811233
to
9f067df
Compare
…into dynamic-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tested the UI as well as hitting the API endpoint publicly and it works as expected.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
fixes #162578
Settings public API !!
Also got an idea , in the effort involved for https://github.com/elastic/synthetics-dev/issues/247